Re: [PATCH v3 1/1] protocol: advertise multiple supported versions

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 14, 2018, 02:44 UTC
Message-ID: <xmqqwopgqsws.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20181113182802.GG30222@szeder.dev>

SZEDER Gábor <szeder.dev@gmail.com> writes:

Show 5 quoted lines

>> +	if (tmp_allowed_versions[0] != config_version)
>> +		for (int i = 1; i < nr_allowed_versions; i++)
>
> We don't do C99 yet, thus the declaration of a loop variable like this
> is not allowed and triggers compiler errors.

I thought we did a weather-balloon to see if this bothers people who build on minority platforms but

	git grep 'for (int'

is coming up empty.

We have been trying designated initializers with weather-balloon changes (both arrays and struct fields) and I somehow thought that we already were trying this out, but apparently that is not the case. Also trailing comma in the enum definition was what we discussed earlier but I do not know if we had weather-balloon for it or not offhand.

Perhaps we should write these down in CodingGuidelines.