Re: [PATCH 1/1] protocol: limit max protocol version per service

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Oct 12, 2018, 23:30 UTC
Message-ID: <20181012233017.GD52080@aiede.svl.corp.google.com>
In-Reply-To: <20181010235303.GB12177@google.com>

Hi,

Josh Steadmon wrote:

Show 10 quoted lines

> So this runs into problems with remote-curl (and possibly other remote
> helpers):
>
> builtin/push.c can declare whatever allowed versions it wants, but those
> are not carried over when remote-curl is started to actually talk to the
> remote. What's worse, remote-curl starts its HTTP connection before it
> knows what command it's actually acting as a helper for.
>
> For now, I'm going to try adding an --allowed_versions flag for the
> remote helpers, but if anyone has a better idea, let me know.

There are some external remote helpers (see "git help remote-helpers" for the documented interface), so alas, they can't take new flags.

That said, you can add a new remote helper capability and then communicate on stdin, or in a pinch you can use the existing "option" capability. Remote helpers are also allowed to query "git config" if they want to (either using the config machinery in config.h or by running "git config").

Thanks, Jonathan