Re: Re* [PATCH v3 1/1] protocol: advertise multiple supported versions

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 14, 2018, 02:31 UTC
Message-ID: <xmqq5zx0s84b.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAGZ79kYv_a8-6dppo3XcNb8wc0RuTSJeOj71Q+3FmEZguBBUiA@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

> "Nobody reads documentation any more, we have too much of it."

Maybe, but spelling it out and writing it down, you can point at it (or hope that other people point at it without making a bad or incorrect rephrase).

> I would have hoped to have a .cocci patch in the bad style category,
> i.e. disallowing the _() function inside the context of BUG().
>
> That said, I like the patch below. Thanks for writing it.

That was a mere weather-baloon, and too early to thank about. Hopefully people can pick nits and come to a final version that can be applied.

I have a few things in it that I think may be debatable. I am not sure if we should talk about being careful not to send localized strings over the wire in that comment, for example.