Re: [PATCH] interpret-trailers: load default config
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 19, 2019, 14:24 UTC
- Message-ID
- <xmqqwohhr6ut.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20190619033728.GA29027@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 6 quoted lines
> Subject: [PATCH] interpret-trailers: load default config > > The interpret-trailers program does not do the usual loading of config > via git_default_config(), and thus does not respect many of the usual > options. In particular, we will not load core.commentChar, even though > the underlying trailer code tries to do so.
"tries to use it"? Eh, it does use it, so, "the underlying trailer code uses its value", would be the correct version of the last sentence.
The underlying trailer.c has two calls to git_config() to lazy-load its own set of config variables (which is justified, as its caller is not necessarily the "interpret-trailers" subcommand), but their callbacks are not good places to call git_default_config() from for obvious reasons. It has to be done in "interpret-trailers" (and other callers of the machinery should already have learned what core.commentChar is with their own configuration calls) like the patch I am reviewing does.
Looks perfect. Thanks.
Show 7 quoted lines
> This can be seen in the accompanying test, where setting > core.commentChar to anything besides "#" results in a failure to treat > the comments correctly. > > Reported-by: Masahiro Yamada <yamada.masahiro@socionext.com> > Signed-off-by: Jeff King <peff@peff.net> > ---
> builtin/interpret-trailers.c | 3 ++ > t/t7513-interpret-trailers.sh | 70 +++++++++++++++++++++-------------- > 2 files changed, 46 insertions(+), 27 deletions(-)