Re: 'git interpret-trailers' is tripped by comment characters other than '#'

From: Christian Couder <christian.couder@gmail.com>
Date: Jun 17, 2019, 05:03 UTC
Message-ID: <CAP8UFD3_kKvBs=rMvBp-K-UPD5mCqVsHRZ1VqGYY7uR8G+H8SQ@mail.gmail.com>
In-Reply-To: <CAK7LNATRQWz9CvosEDzNHCZHaxpzozAjGyo5VSKpQhui9zhSFQ@mail.gmail.com>

On Mon, Jun 17, 2019 at 6:33 AM Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

Show 15 quoted lines

>
> On Sat, Jun 15, 2019 at 5:41 PM Christian Couder
> <christian.couder@gmail.com> wrote:
> >
> > > I do wonder if the trailer code is correct to always respect it, though.
> > > For example, in "git log" output we'd expect to see commit messages from
> > > people with all sorts of config. I suppose the point is that their
> > > comment characters wouldn't make it into the commit object at all, so
> > > the right answer there is probably not to look for comment characters at
> > > all.
> >
> > Would you suggest an option, maybe called `--ignore-comments` to ignore them?
>
> Since 'git interpret-trailers' already ignores lines starting with '#',
> is this option true by default?

Sorry, I should have suggested something called --unstrip-comments or --ignore-comment-char that would make 'git interpret-trailers' stop stripping lines that start with the comment character.