Re: 'git interpret-trailers' is tripped by comment characters other than '#'

From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Jun 17, 2019, 04:32 UTC
Message-ID: <CAK7LNATRQWz9CvosEDzNHCZHaxpzozAjGyo5VSKpQhui9zhSFQ@mail.gmail.com>
In-Reply-To: <CAP8UFD2dhGqOxXJMTZhNSM5G4sp6PvKF+0R5KVk6YjAQi3Sccw@mail.gmail.com>

On Sat, Jun 15, 2019 at 5:41 PM Christian Couder <christian.couder@gmail.com> wrote:

Show 22 quoted lines

>
> On Fri, Jun 14, 2019 at 5:10 PM Jeff King <peff@peff.net> wrote:
> >
> > On Fri, Jun 14, 2019 at 08:35:04PM +0900, Masahiro Yamada wrote:
> >
> > > Perhaps, 'git interpret-trailers' should be changed
> > > to recognize core.commentChar ?
> >
> > It looks like the trailer code does respect it, but the
> > interpret-trailers program never loads the config. Does the patch below
> > make your problem go away?
>
> It seems to me to be the right analysis and the right fix too.
>
> > I do wonder if the trailer code is correct to always respect it, though.
> > For example, in "git log" output we'd expect to see commit messages from
> > people with all sorts of config. I suppose the point is that their
> > comment characters wouldn't make it into the commit object at all, so
> > the right answer there is probably not to look for comment characters at
> > all.
>
> Would you suggest an option, maybe called `--ignore-comments` to ignore them?

Since 'git interpret-trailers' already ignores lines starting with '#', is this option true by default?

> Thanks,
> Christian.

-- 
Best Regards
Masahiro Yamada