git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] l10n: localizable upload progress messages

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 24, 2019, 18:04 UTC
Message-ID
<xmqqwohahnbf.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<2074c719-a077-35c4-f30b-769580e17879@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
> Thanks for educating me. Given your explanations, wouldn't it be much
> more natural to keep the prefix with the unit instead of separating
> them, as the patch does?
Yup, that "octet" comment was illuminating.  Great discussion.

Also I am with Duy's message in the other subthread. We should keep the number placeholder "%[udf]" and the unit in a single string), instead of hardcoding the "a number must come and then unit" in the code.

Thanks.
Previous: Johannes SixtNext: brian m. carlson
Message 9 of 10 in “l10n: localizable upload progress messages”
  1. l10n: localizable upload progress messagesDimitriy Ryazantcev, Jun 22, 2019
  2. Duy NguyenJun 22, 2019
  3. DimitriyJun 22, 2019
  4. Junio C HamanoJun 24, 2019
  5. Johannes SixtJun 22, 2019
  6. brian m. carlsonJun 23, 2019
  7. DimitriyJun 23, 2019
  8. Johannes SixtJun 23, 2019
  9. Junio C HamanoJun 24, 2019
  10. brian m. carlsonJun 23, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.