From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 24 Jun 2019 18:04:36 GMT
Subject: Re: [PATCH v3] l10n: localizable upload progress messages
Message-ID: <xmqqwohahnbf.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <2074c719-a077-35c4-f30b-769580e17879@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

> Thanks for educating me. Given your explanations, wouldn't it be much
> more natural to keep the prefix with the unit instead of separating
> them, as the patch does?

Yup, that "octet" comment was illuminating.  Great discussion.

Also I am with Duy's message in the other subthread.  We should keep
the number placeholder "%[udf]" and the unit in a single string),
instead of hardcoding the "a number must come and then unit" in the
code.

Thanks.