git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] test_date.c: Remove reference to GIT_TEST_DATE_NOW

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 9, 2019, 19:44 UTC
Message-ID
<xmqqwoehi7ae.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20190909172954.GC30470@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 15 quoted lines
> On Sun, Sep 08, 2019 at 06:47:11PM -0700, Stephen P. Smith wrote:
>
>> Remove the reference to the GIT_TEST_DATE_NOW which is done in date.c.
>> The intialization of variable x with the value from GIT_TEST_DATE_NOW
>> is unneeded since x is initalized by skip_prefix().
>
> It took me a minute to understand what this second sentence meant. I'd
> have actually expected "x" to go away, looking at the diff context.
>
> Maybe a more clear explanation would be: We can't get rid of the "x"
> variable, since it serves as a generic scratch variable for parsing
> later in the function.
>
> (I'd also probably have just rolled this into patch 1, but I'm OK with
> it either way).
Thanks for saying everything ;-)  I have nothing to add.
Previous: Jeff KingNext: Stephen P. Smith
Message 4 of 12 in “Date test code clean-up”
  1. 0/2 Date test code clean-upStephen P. Smith, Sep 9, 2019
  2. 2/2 test_date.c: Remove reference to GIT_TEST_DATE_NOWStephen P. Smith, Sep 9, 2019
  3. Jeff KingSep 9, 2019
  4. Junio C HamanoSep 9, 2019
  5. 1/2 Quit passing 'now' to date codeStephen P. Smith, Sep 9, 2019
  6. Jeff KingSep 9, 2019
  7. Junio C HamanoSep 9, 2019
  8. 0/2 Date test code clean-upStephen P. Smith, Sep 12, 2019
  9. 2/2 test_date.c: Remove reference to GIT_TEST_DATE_NOWStephen P. Smith, Sep 12, 2019
  10. 1/2 Quit passing 'now' to date codeStephen P. Smith, Sep 12, 2019
  11. Jeff KingSep 13, 2019
  12. Junio C HamanoSep 13, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.