git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] Date test code clean-up

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 9, 2019, 18:32 UTC
Message-ID
<xmqqh85ljp60.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20190909014711.3894-1-ischis2@cox.net>
"Stephen P. Smith" <ischis2@cox.net> writes:
> As part of a previous patch submission[1], a cleanup patch was
> suggested to remove a now unnecessary passing of a date environment
> variable to the production code.

It looks like that the idea to realize that get_time() that is aware of GIT_TEST_DATE_NOW is always called before functions like show_date_relative(), approxidate_str() and approxidate_careful(), and arrange it to be called in the lower level of the callchain, which makes sense to me.

Thanks for tying the loose end.
Previous: Jeff KingNext: Stephen P. Smith
Message 7 of 12 in “Date test code clean-up”
  1. 0/2 Date test code clean-upStephen P. Smith, Sep 9, 2019
  2. 2/2 test_date.c: Remove reference to GIT_TEST_DATE_NOWStephen P. Smith, Sep 9, 2019
  3. Jeff KingSep 9, 2019
  4. Junio C HamanoSep 9, 2019
  5. 1/2 Quit passing 'now' to date codeStephen P. Smith, Sep 9, 2019
  6. Jeff KingSep 9, 2019
  7. Junio C HamanoSep 9, 2019
  8. 0/2 Date test code clean-upStephen P. Smith, Sep 12, 2019
  9. 2/2 test_date.c: Remove reference to GIT_TEST_DATE_NOWStephen P. Smith, Sep 12, 2019
  10. 1/2 Quit passing 'now' to date codeStephen P. Smith, Sep 12, 2019
  11. Jeff KingSep 13, 2019
  12. Junio C HamanoSep 13, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.