From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 09 Sep 2019 19:44:25 GMT
Subject: Re: [PATCH 2/2] test_date.c: Remove reference to GIT_TEST_DATE_NOW
Message-ID: <xmqqwoehi7ae.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190909172954.GC30470@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Sun, Sep 08, 2019 at 06:47:11PM -0700, Stephen P. Smith wrote:
>
>> Remove the reference to the GIT_TEST_DATE_NOW which is done in date.c.
>> The intialization of variable x with the value from GIT_TEST_DATE_NOW
>> is unneeded since x is initalized by skip_prefix().
>
> It took me a minute to understand what this second sentence meant. I'd
> have actually expected "x" to go away, looking at the diff context.
>
> Maybe a more clear explanation would be: We can't get rid of the "x"
> variable, since it serves as a generic scratch variable for parsing
> later in the function.
>
> (I'd also probably have just rolled this into patch 1, but I'm OK with
> it either way).

Thanks for saying everything ;-)  I have nothing to add.