Re: [PATCH v1 0/2] git-gui: reduce Tcl version requirement from 8.6 to 8.5

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 16, 2020, 15:48 UTC
Message-ID: <xmqqwo7k8fnk.fsf@gitster.c.googlers.com>
In-Reply-To: <CAPig+cRXD_bjUL6=daEAx7VnAy_nw9bao6rLK9xwTCYJSk48Qw@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 15 quoted lines

> On Sat, Mar 14, 2020 at 9:47 PM Pratyush Yadav <me@yadavpratyush.com> wrote:
>> Some MacOS distributions ship with Tcl 8.5. This means we can't use
>> TclOO. So, use our homegrown class.tcl instead.
>
> It should be mentioned that this patch series fixes a regression in
> Git v2.25 in which git-gui could not even be launched on Mac OS. The
> problem was reported here[1] a couple months ago.
>
> I performed some rudimentary testing of this patch series on Mac OS,
> and it appears to be working as expected; it certainly fixes the
> problem of git-gui not launching on Mac OS. (I did notice a
> misbehavior related to the original patch which caused git-gui to be
> unusable on Mac OS in v2.25, but I suspect that misbehavior is not
> related to or caused by this patch series, thus shouldn't prevent its
> acceptance.)

I was actually hesitant to see this kind of change for the first time this late in the cycle (the code may work with old Tcl/Tk but do we know it does with newer ones?)

I'll pull git-gui updates when Pratyush tells me to, which would happen before the final (scheduled on 22nd). I'll trust git-gui maintainer's decision to include these changes in it, or to cook longer to wait for the 2.27 cycle. Comments like yours that help Pratyush make the right judgment is greatly appreciated.

Thanks.