git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1 0/2] git-gui: reduce Tcl version requirement from 8.6 to 8.5

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Mar 15, 2020, 18:54 UTC
Message-ID
<CAPig+cRXD_bjUL6=daEAx7VnAy_nw9bao6rLK9xwTCYJSk48Qw@mail.gmail.com>
In-Reply-To
<20200314224159.14174-1-me@yadavpratyush.com>
On Sat, Mar 14, 2020 at 9:47 PM Pratyush Yadav <me@yadavpratyush.com> wrote:
> Some MacOS distributions ship with Tcl 8.5. This means we can't use
> TclOO. So, use our homegrown class.tcl instead.

It should be mentioned that this patch series fixes a regression in Git v2.25 in which git-gui could not even be launched on Mac OS. The problem was reported here[1] a couple months ago.

I performed some rudimentary testing of this patch series on Mac OS, and it appears to be working as expected; it certainly fixes the problem of git-gui not launching on Mac OS. (I did notice a misbehavior related to the original patch which caused git-gui to be unusable on Mac OS in v2.25, but I suspect that misbehavior is not related to or caused by this patch series, thus shouldn't prevent its acceptance.)

[1]: https://github.com/prati0100/git-gui/issues/26
Previous: Pratyush YadavNext: Junio C Hamano
Message 4 of 12 in “git-gui: reduce Tcl version requirement from 8.6 to 8.5”
  1. 0/2 git-gui: reduce Tcl version requirement from 8.6 to 8.5Pratyush Yadav, Mar 14, 2020
  2. 2/2 git-gui: create a new namespace for chord script evaluationPratyush Yadav, Mar 14, 2020
  3. 1/2 git-gui: reduce Tcl version requirement from 8.6 to 8.5Pratyush Yadav, Mar 14, 2020
  4. Eric SunshineMar 15, 2020
  5. Junio C HamanoMar 16, 2020
  6. Pratyush YadavMar 17, 2020
  7. Eric SunshineMar 19, 2020
  8. 0/2 git-gui: reduce Tcl version requirement from 8.6 to 8.5Pratyush Yadav, Mar 17, 2020
  9. 1/2 git-gui: reduce Tcl version requirement from 8.6 to 8.5Pratyush Yadav, Mar 17, 2020
  10. 2/2 git-gui: create a new namespace for chord script evaluationPratyush Yadav, Mar 17, 2020
  11. Eric SunshineMar 19, 2020
  12. Pratyush YadavMar 19, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.