git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] git-gui: reduce Tcl version requirement from 8.6 to 8.5

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Mar 19, 2020, 15:22 UTC
Message-ID
<CAPig+cQ0YJB25fFaKV2URz39zdS8BwMwwB-a6VJzekkQRLEHpw@mail.gmail.com>
In-Reply-To
<20200317132921.7222-1-me@yadavpratyush.com>
On Tue, Mar 17, 2020 at 9:29 AM Pratyush Yadav <me@yadavpratyush.com> wrote:
Show 9 quoted lines
> Some MacOS distributions ship with Tcl 8.5. This means we can't use
> TclOO. So, use our homegrown class.tcl instead.
>
> Changes in v2:
> - Add a note _after_ checking if the user agreed to the deletion.
>   Otherwise, if the user denies, two "zombie" notes are left lying
>   around which will never be activated. This means that the chord won't
>   complete and the index won't be unlocked, leading to git-gui becoming
>   frozen.

Thanks. I did some light testing on Mac OS. This re-roll seems to address the reported problems[1] and allows the new "delete unstaged file" feature to work on older Tcl. As a fix for the Git 2.25 regression which resulted in git-gui being unable to launch on Mac OS, this path series seems "good to go".

[1]: https://github.com/prati0100/git-gui/issues/26
Previous: Pratyush YadavNext: Pratyush Yadav
Message 11 of 12 in “git-gui: reduce Tcl version requirement from 8.6 to 8.5”
  1. 0/2 git-gui: reduce Tcl version requirement from 8.6 to 8.5Pratyush Yadav, Mar 14, 2020
  2. 2/2 git-gui: create a new namespace for chord script evaluationPratyush Yadav, Mar 14, 2020
  3. 1/2 git-gui: reduce Tcl version requirement from 8.6 to 8.5Pratyush Yadav, Mar 14, 2020
  4. Eric SunshineMar 15, 2020
  5. Junio C HamanoMar 16, 2020
  6. Pratyush YadavMar 17, 2020
  7. Eric SunshineMar 19, 2020
  8. 0/2 git-gui: reduce Tcl version requirement from 8.6 to 8.5Pratyush Yadav, Mar 17, 2020
  9. 1/2 git-gui: reduce Tcl version requirement from 8.6 to 8.5Pratyush Yadav, Mar 17, 2020
  10. 2/2 git-gui: create a new namespace for chord script evaluationPratyush Yadav, Mar 17, 2020
  11. Eric SunshineMar 19, 2020
  12. Pratyush YadavMar 19, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.