git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] Make refs_ref_exists public

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 18, 2020, 20:39 UTC
Message-ID
<xmqqwo1vwuwx.fsf@gitster.c.googlers.com>
In-Reply-To
<5e29fa74dc70b5e36ace27ed6d83060cf0925681.1597753075.git.gitgitgadget@gmail.com>
"Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes:
> Subject: Re: [PATCH 1/3] Make refs_ref_exists public
Documentation/SubmittingPatches[[describe-changes]]

Applies to all three patches and probably other recent topics from you.

Show 34 quoted lines
> From: Han-Wen Nienhuys <hanwen@google.com>
>
> Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
> ---
>  refs.c | 2 +-
>  refs.h | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/refs.c b/refs.c
> index cf91711968..d46080f4b6 100644
> --- a/refs.c
> +++ b/refs.c
> @@ -313,7 +313,7 @@ int read_ref(const char *refname, struct object_id *oid)
>  	return read_ref_full(refname, RESOLVE_REF_READING, oid, NULL);
>  }
>  
> -static int refs_ref_exists(struct ref_store *refs, const char *refname)
> +int refs_ref_exists(struct ref_store *refs, const char *refname)
>  {
>  	return !!refs_resolve_ref_unsafe(refs, refname, RESOLVE_REF_READING, NULL, NULL);
>  }
> diff --git a/refs.h b/refs.h
> index 29e28124cd..04bd25019f 100644
> --- a/refs.h
> +++ b/refs.h
> @@ -105,6 +105,8 @@ int refs_verify_refname_available(struct ref_store *refs,
>  				  const struct string_list *skip,
>  				  struct strbuf *err);
>  
> +int refs_ref_exists(struct ref_store *refs, const char *refname);
> +
>  int ref_exists(const char *refname);
>  
>  int should_autocreate_reflog(const char *refname);
Previous: Han-Wen Nienhuys via GitGitGadgetNext: Han-Wen Nienhuys via GitGitGadget
Message 3 of 23 in “Use refs API for handling sundry pseudorefs”
  1. 0/3 Use refs API for handling sundry pseudorefsHan-Wen Nienhuys via GitGitGadget, Aug 18, 2020
  2. 1/3 Make refs_ref_exists publicHan-Wen Nienhuys via GitGitGadget, Aug 18, 2020
  3. Junio C HamanoAug 18, 2020
  4. 2/3 Treat CHERRY_PICK_HEAD as a pseudo refHan-Wen Nienhuys via GitGitGadget, Aug 18, 2020
  5. Junio C HamanoAug 18, 2020
  6. Han-Wen NienhuysAug 19, 2020
  7. Junio C HamanoAug 19, 2020
  8. 3/3 Treat REVERT_HEAD as a pseudo refHan-Wen Nienhuys via GitGitGadget, Aug 18, 2020
  9. Junio C HamanoAug 18, 2020
  10. Junio C HamanoAug 18, 2020
  11. 0/4 Use refs API for handling sundry pseudorefsHan-Wen Nienhuys via GitGitGadget, Aug 19, 2020
  12. 1/4 refs: make refs_ref_exists publicHan-Wen Nienhuys via GitGitGadget, Aug 19, 2020
  13. 2/4 sequencer: treat CHERRY_PICK_HEAD as a pseudo refHan-Wen Nienhuys via GitGitGadget, Aug 19, 2020
  14. 3/4 builtin/commit: suggest update-ref for pseudoref removalHan-Wen Nienhuys via GitGitGadget, Aug 19, 2020
  15. Junio C HamanoAug 19, 2020
  16. Han-Wen NienhuysAug 21, 2020
  17. 4/4 sequencer: treat REVERT_HEAD as a pseudo refHan-Wen Nienhuys via GitGitGadget, Aug 19, 2020
  18. 0/4 Use refs API for handling sundry pseudorefsHan-Wen Nienhuys via GitGitGadget, Aug 21, 2020
  19. 4/4 sequencer: treat REVERT_HEAD as a pseudo refHan-Wen Nienhuys via GitGitGadget, Aug 21, 2020
  20. 2/4 sequencer: treat CHERRY_PICK_HEAD as a pseudo refHan-Wen Nienhuys via GitGitGadget, Aug 21, 2020
  21. 1/4 refs: make refs_ref_exists publicHan-Wen Nienhuys via GitGitGadget, Aug 21, 2020
  22. 3/4 builtin/commit: suggest update-ref for pseudoref removalHan-Wen Nienhuys via GitGitGadget, Aug 21, 2020
  23. Junio C HamanoAug 21, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.