git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 3/4] builtin/commit: suggest update-ref for pseudoref removal

From
Han-Wen Nienhuys via GitGitGadget <gitgitgadget@gmail.com>
Date
Aug 21, 2020, 16:59 UTC
Message-ID
<8aacde69c8c4689b6b68f11a310a308595ed49ad.1598029177.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.706.v3.git.1598029177.gitgitgadget@gmail.com>
From: Han-Wen Nienhuys <hanwen@google.com>

When pseudorefs move to a different ref storage mechanism, pseudorefs no longer can be removed with 'rm'. Instead, suggest a "update-ref -d" command, which will work regardless of ref storage backend.

Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>
---
 builtin/commit.c | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)
diff --git a/builtin/commit.c b/builtin/commit.c
index 69ac78d5e5..671721c385 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -847,21 +847,19 @@ static int prepare_to_commit(const char *index_file, const char *prefix,
 			if (cleanup_mode == COMMIT_MSG_CLEANUP_SCISSORS &&
 				!merge_contains_scissors)
 				wt_status_add_cut_line(s->fp);
-			status_printf_ln(s, GIT_COLOR_NORMAL,
-			    whence == FROM_MERGE
-				? _("\n"
-					"It looks like you may be committing a merge.\n"
-					"If this is not correct, please remove the file\n"
-					"	%s\n"
-					"and try again.\n")
-				: _("\n"
-					"It looks like you may be committing a cherry-pick.\n"
-					"If this is not correct, please remove the file\n"
-					"	%s\n"
-					"and try again.\n"),
+			status_printf_ln(
+				s, GIT_COLOR_NORMAL,
 				whence == FROM_MERGE ?
-					git_path_merge_head(the_repository) :
-					git_path_cherry_pick_head(the_repository));
+					      _("\n"
+					  "It looks like you may be committing a merge.\n"
+					  "If this is not correct, please run\n"
+					  "	git update-ref -d MERGE_HEAD\n"
+					  "and try again.\n") :
+					      _("\n"
+					  "It looks like you may be committing a cherry-pick.\n"
+					  "If this is not correct, please run\n"
+					  "	git update-ref -d CHERRY_PICK_HEAD\n"
+					  "and try again.\n"));
 		}
 
 		fprintf(s->fp, "\n");
-- 
gitgitgadget
Previous: Han-Wen Nienhuys via GitGitGadgetNext: Junio C Hamano
Message 22 of 23 in “Use refs API for handling sundry pseudorefs”
  1. 0/3 Use refs API for handling sundry pseudorefsHan-Wen Nienhuys via GitGitGadget, Aug 18, 2020
  2. 1/3 Make refs_ref_exists publicHan-Wen Nienhuys via GitGitGadget, Aug 18, 2020
  3. Junio C HamanoAug 18, 2020
  4. 2/3 Treat CHERRY_PICK_HEAD as a pseudo refHan-Wen Nienhuys via GitGitGadget, Aug 18, 2020
  5. Junio C HamanoAug 18, 2020
  6. Han-Wen NienhuysAug 19, 2020
  7. Junio C HamanoAug 19, 2020
  8. 3/3 Treat REVERT_HEAD as a pseudo refHan-Wen Nienhuys via GitGitGadget, Aug 18, 2020
  9. Junio C HamanoAug 18, 2020
  10. Junio C HamanoAug 18, 2020
  11. 0/4 Use refs API for handling sundry pseudorefsHan-Wen Nienhuys via GitGitGadget, Aug 19, 2020
  12. 1/4 refs: make refs_ref_exists publicHan-Wen Nienhuys via GitGitGadget, Aug 19, 2020
  13. 2/4 sequencer: treat CHERRY_PICK_HEAD as a pseudo refHan-Wen Nienhuys via GitGitGadget, Aug 19, 2020
  14. 3/4 builtin/commit: suggest update-ref for pseudoref removalHan-Wen Nienhuys via GitGitGadget, Aug 19, 2020
  15. Junio C HamanoAug 19, 2020
  16. Han-Wen NienhuysAug 21, 2020
  17. 4/4 sequencer: treat REVERT_HEAD as a pseudo refHan-Wen Nienhuys via GitGitGadget, Aug 19, 2020
  18. 0/4 Use refs API for handling sundry pseudorefsHan-Wen Nienhuys via GitGitGadget, Aug 21, 2020
  19. 4/4 sequencer: treat REVERT_HEAD as a pseudo refHan-Wen Nienhuys via GitGitGadget, Aug 21, 2020
  20. 2/4 sequencer: treat CHERRY_PICK_HEAD as a pseudo refHan-Wen Nienhuys via GitGitGadget, Aug 21, 2020
  21. 1/4 refs: make refs_ref_exists publicHan-Wen Nienhuys via GitGitGadget, Aug 21, 2020
  22. 3/4 builtin/commit: suggest update-ref for pseudoref removalHan-Wen Nienhuys via GitGitGadget, Aug 21, 2020
  23. Junio C HamanoAug 21, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.