Re: [PATCH 2/3] Treat CHERRY_PICK_HEAD as a pseudo ref
- From
Han-Wen Nienhuys <hanwen@google.com>
- Date
- Aug 19, 2020, 15:04 UTC
- Message-ID
- <CAFQ2z_PYpP4WdUaaG4=fOQ_7RLLmGLjuBQaE2yQVA9=7j9XcuQ@mail.gmail.com>
- In-Reply-To
- <xmqqsgcjwtpv.fsf@gitster.c.googlers.com>
On Tue, Aug 18, 2020 at 11:05 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
> > "Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes: > > > From: Han-Wen Nienhuys <hanwen@google.com> > > > > Check for existence and delete CHERRY_PICK_HEAD through ref functions. > > This will help cherry-pick work with alternate ref storage backends. > > These two sentences are true, but this patch does another thing that > is not advertised here. It stops recommending removal of > CHERRY_PICK_HEAD from the filesystem with "rm" (or using "git > update-ref -d" for that matter) as a way to avoid recording the > current commit as a cherry-pick.
..
> Does "git cherry-pick --abort" only remove CHERRY_PICK_HEAD without > doing any other damage to the working tree files and to the index?
Good catch. I just added cherry-pick --abort without much thinking. I reverted to update-ref -d which should be equivalent to what is currently recommended.
-- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado