Re: [PATCH v2 1/1] git-compat-util: add a test balloon for C99 support

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 17, 2021, 08:49 UTC
Message-ID: <xmqqwnl72mm1.fsf@gitster.g>
In-Reply-To: <YZPGKHYE/9km1rH5@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 12 quoted lines

> On Tue, Nov 16, 2021 at 01:54:27PM +0100, Ævar Arnfjörð Bjarmason wrote:
>
>> But IMO this whole thing of trying to make this work on every compiler
>> etc. just isn't worth it.
>> 
>> Let's just start using C99 features, and if anyone's compiler breaks on
>> something like CentOS 6 document that they'll need to tweak a flag
>> somewhere. We already know that works for all the other C99 features we
>> have, there seems to just be this one exception of the ancient GCC
>> version in this particular case.
>
> Yeah, I definitely agree with this sentiment.

+1, provided that we are not saying that "we will start using any random C99 features" without limit. I do appreciate the way the previous efforts were conducted, to start with small test balloons that can easily be backed out and leaving it there for sufficiently long time.