Re: [PATCH v2 1/1] git-compat-util: add a test balloon for C99 support

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Nov 17, 2021, 02:53 UTC
Message-ID: <YZRurUdyB/cGL6Y3@camp.crustytoothpaste.net>
In-Reply-To: <YZPGKHYE/9km1rH5@coredump.intra.peff.net>

On 2021-11-16 at 14:54:32, Jeff King wrote:

Show 12 quoted lines

> On Tue, Nov 16, 2021 at 01:54:27PM +0100, Ævar Arnfjörð Bjarmason wrote:
> 
> > But IMO this whole thing of trying to make this work on every compiler
> > etc. just isn't worth it.
> > 
> > Let's just start using C99 features, and if anyone's compiler breaks on
> > something like CentOS 6 document that they'll need to tweak a flag
> > somewhere. We already know that works for all the other C99 features we
> > have, there seems to just be this one exception of the ancient GCC
> > version in this particular case.
> 
> Yeah, I definitely agree with this sentiment.

Unfortunately, we cannot do this without some sort of patch because our CI will be broken. I'm fine if we want to drop GCC 4.8, but we need to be explicit about that or we need to add flags to make it work. We also need at least something to make Windows work. Dscho will not be happy if we just leave it broken.

So I think some version of this patch or something similar needs to be adopted. I'll try to get a v3 out relatively soon that fixes these issues and drops -std=gnu99 from CFLAGS, which seems to be the approach people are most desirous of.

-- 
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA