Re: [PATCH v2 2/3] t/*: avoid "whitelist"
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 19, 2022, 19:44 UTC
- Message-ID
- <xmqqwnc8anvh.fsf@gitster.g>
- In-Reply-To
- <75cc0f43-d9a5-45d3-5e36-dd20acfebf50@github.com>
Derrick Stolee <derrickstolee@github.com> writes:
Show 13 quoted lines
>> GIT_TEST_PASSING_SANITIZE_LEAK=<bool> when compiled with >> SANITIZE=leak will, when true, only run those tests that declare >> themselves leak-free by setting "TEST_PASSES_SANITIZE_LEAK=true" >> before sourcing "test-lib.sh". This test mode is used by the >> "linux-leaks" CI target. > > Another iteration: > > GIT_TEST_PASSING_SANITIZE_LEAK=<bool> focuses the test suite on finding > memory leaks. When the variable is true and Git is compiled with > SANITIZE=leak, only run those tests that declare themselves leak-free by > setting "TEST_PASSES_SANITIZE_LEAK=true" before sourcing "test-lib.sh". > This test mode is used by the "linux-leaks" CI target.
Sounds good. These scripts opt into the sanitize-leak tests by declaring themselves to be leak-free and that is captured very well without using the *list word ;-)