[PATCH v3 5/5] transport.c: avoid "whitelist"
- From
Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Jul 19, 2022, 18:32 UTC
- Message-ID
- <a4f31877b15e46413cb62378577d95886720b020.1658255537.git.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.1274.v3.git.1658255537.gitgitgadget@gmail.com>
From: Derrick Stolee <derrickstolee@github.com>
The word "whitelist" has cultural implications that are not inclusive. Thankfully, it is not difficult to reword and avoid its use.
The GIT_ALLOW_PROTOCOL environment variable was referred to as a "whitelist", but the word "allow" is already part of the variable. Replace "whitelist" with "allow_list" in these cases to demonstrate that we are processing a list of allowed protocols.
Signed-off-by: Derrick Stolee <derrickstolee@github.com> --- transport.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/transport.c b/transport.c index 52db7a3cb09..b51e991e443 100644 --- a/transport.c +++ b/transport.c @@ -940,7 +940,7 @@ static int external_specification_len(const char *url) return strchr(url, ':') - url; } -static const struct string_list *protocol_whitelist(void) +static const struct string_list *protocol_allow_list(void) { static int enabled = -1; static struct string_list allowed = STRING_LIST_INIT_DUP; @@ -1020,9 +1020,9 @@ static enum protocol_allow_config get_protocol_config(const char *type) int is_transport_allowed(const char *type, int from_user) { - const struct string_list *whitelist = protocol_whitelist(); - if (whitelist) - return string_list_has_string(whitelist, type); + const struct string_list *allow_list = protocol_allow_list(); + if (allow_list) + return string_list_has_string(allow_list, type); switch (get_protocol_config(type)) { case PROTOCOL_ALLOW_ALWAYS:
-- gitgitgadget