From: Junio C Hamano Date: Tue, 19 Jul 2022 19:44:34 GMT Subject: Re: [PATCH v2 2/3] t/*: avoid "whitelist" Message-ID: In-Reply-To: <75cc0f43-d9a5-45d3-5e36-dd20acfebf50@github.com> Derrick Stolee writes: >> GIT_TEST_PASSING_SANITIZE_LEAK= when compiled with >> SANITIZE=leak will, when true, only run those tests that declare >> themselves leak-free by setting "TEST_PASSES_SANITIZE_LEAK=true" >> before sourcing "test-lib.sh". This test mode is used by the >> "linux-leaks" CI target. > > Another iteration: > > GIT_TEST_PASSING_SANITIZE_LEAK= focuses the test suite on finding > memory leaks. When the variable is true and Git is compiled with > SANITIZE=leak, only run those tests that declare themselves leak-free by > setting "TEST_PASSES_SANITIZE_LEAK=true" before sourcing "test-lib.sh". > This test mode is used by the "linux-leaks" CI target. Sounds good. These scripts opt into the sanitize-leak tests by declaring themselves to be leak-free and that is captured very well without using the *list word ;-)