Re: [PATCH v2] promisor-remote: fix xcalloc() argument order

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 24, 2022, 15:58 UTC
Message-ID: <xmqqwnax8wgy.fsf@gitster.g>
In-Reply-To: <20220823095733.58685-1-szeder.dev@gmail.com>

SZEDER Gábor <szeder.dev@gmail.com> writes:

Show 8 quoted lines

> Patch generated with:
>
>   make SPATCH_FLAGS=--recursive-includes contrib/coccinelle/xcalloc.cocci.patch
>
> Our default SPATCH_FLAGS ('--all-includes') doesn't catch this
> transformation by default, unless used in combination with a large-ish
> SPATCH_BATCH_SIZE which happens to put 'promisor-remote.c' with a file
> that includes 'repository.h' directly in the same batch.

Our default SPATCH_FLAGS is actually

    SPATCH_FLAGS = --all-includes --patch .

and I am wondering how "--patch ." part (or droppage thereof due to overriding it from the command line) affects the outcome.

In any case, good finding how the header file inclusion was affected with batch-size and this option that solved a mystery. Thanks.