Re: [PATCH] promisor-remote: fix xcalloc() argument order
Junio C Hamano <gitster@pobox.com> writes:
> ... FWIW, "make coccicheck" with what I happen to have
> notices it.
Oops, that was a serious typo. "notices" -> "fails to notice".
Show 29 quoted lines
> $ spatch version
> spatch version 1.1.1 compiled with OCaml version 4.13.1
> Flags passed to the configure script: --prefix=/usr --sysconfdir=/etc --libdir=/usr/lib --enable-ocaml --enable-python --enable-opt
> OCaml scripting support: yes
> Python scripting support: yes
> Syntax of regular expressions: PCRE
>
> Anyway, the patch is correct.
>
> Thanks, will queue.
>
>> Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
>> ---
>> promisor-remote.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/promisor-remote.c b/promisor-remote.c
>> index 5b33f88bca..68f46f5ec7 100644
>> --- a/promisor-remote.c
>> +++ b/promisor-remote.c
>> @@ -146,7 +146,7 @@ static void promisor_remote_init(struct repository *r)
>> if (r->promisor_remote_config)
>> return;
>> config = r->promisor_remote_config =
>> - xcalloc(sizeof(*r->promisor_remote_config), 1);
>> + xcalloc(1, sizeof(*r->promisor_remote_config));
>> config->promisors_tail = &config->promisors;
>>
>> repo_config(r, promisor_remote_config, config);
Junio C Hamano <gitster@pobox.com>