[PATCH v2] promisor-remote: fix xcalloc() argument order
- From
SZEDER Gábor <szeder.dev@gmail.com>
- Date
- Aug 23, 2022, 09:57 UTC
- Message-ID
- <20220823095733.58685-1-szeder.dev@gmail.com>
- In-Reply-To
- <20220822213408.662482-1-szeder.dev@gmail.com>
Pass the number of elements first and their size second, as expected by xcalloc().
Patch generated with:
make SPATCH_FLAGS=--recursive-includes contrib/coccinelle/xcalloc.cocci.patch
Our default SPATCH_FLAGS ('--all-includes') doesn't catch this transformation by default, unless used in combination with a large-ish SPATCH_BATCH_SIZE which happens to put 'promisor-remote.c' with a file that includes 'repository.h' directly in the same batch.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> --- promisor-remote.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/promisor-remote.c b/promisor-remote.c index 5b33f88bca..68f46f5ec7 100644 --- a/promisor-remote.c +++ b/promisor-remote.c @@ -146,7 +146,7 @@ static void promisor_remote_init(struct repository *r) if (r->promisor_remote_config) return; config = r->promisor_remote_config = - xcalloc(sizeof(*r->promisor_remote_config), 1); + xcalloc(1, sizeof(*r->promisor_remote_config)); config->promisors_tail = &config->promisors; repo_config(r, promisor_remote_config, config);
-- 2.37.2.880.g3b8fb2ce68