git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4alt/4] attr: drop DEBUG_ATTR code

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 6, 2022, 17:02 UTC
Message-ID
<xmqqwn9clwba.fsf@gitster.g>
In-Reply-To
<Yz7Wx4kVbrZFfm0s@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 10 quoted lines
> On Thu, Oct 06, 2022 at 09:13:41AM -0400, Jeff King wrote:
>
>> The other obvious option is to just delete this debug code, and remove
>> the unused parameter. I'm not sure if the trace would ever be useful or
>> not, and I am mostly retaining it out of the logic of "well, somebody
>> bothered to write it". I think the const issue has been there since
>> e810e06357 (attr: tighten const correctness with git_attr and
>> match_attr, 2017-01-27).
>
> And here's what that would look like.

I highly suspect that I was the one who bothered, and while I admit it was useful while developing the attribute subsystem, I haven't needed it for the past 10 or so years.

So unless there are some folks who want to throw everything into the trace2 floodstream, I would prefer this alternative over the other one.

Thanks.  All four patches look good.
Previous: Jeff KingNext: Derrick Stolee
Message 7 of 11 in “a few small unused-parameter fixes”
  1. 0/4 a few small unused-parameter fixesJeff King, Oct 6, 2022
  2. 1/4 test-submodule: inline resolve_relative_url() functionJeff King, Oct 6, 2022
  3. 2/4 multi-pack-index: avoid writing to global in option callbackJeff King, Oct 6, 2022
  4. 3/4 commit: avoid writing to global in option callbackJeff King, Oct 6, 2022
  5. 4/4 attr: convert DEBUG_ATTR to use trace APIJeff King, Oct 6, 2022
  6. attr: drop DEBUG_ATTR codeJeff King, Oct 6, 2022
  7. Junio C HamanoOct 6, 2022
  8. Derrick StoleeOct 6, 2022
  9. Junio C HamanoOct 6, 2022
  10. Jeff KingOct 11, 2022
  11. Jeff KingOct 11, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.