Re: [PATCH 4alt/4] attr: drop DEBUG_ATTR code

From: Jeff King <peff@peff.net>
Date: Oct 11, 2022, 00:26 UTC
Message-ID: <Y0S4TWdeK0dSL3VZ@coredump.intra.peff.net>
In-Reply-To: <fb4cfbd3-e738-f1e8-18f7-d4e90050b8b5@github.com>

On Thu, Oct 06, 2022 at 02:33:08PM -0400, Derrick Stolee wrote:

Show 9 quoted lines

> Are you implying that you want to use the second version, that
> deletes the information entirely? I'm leaning towards deleting
> it.
> 
> If not, and we should keep using traces, I do notice that the
> original version of the patch uses trace_printf_key() instead
> of a trace2 method. I think this is fine, too, since it's
> likely only to be used by Git developers, who could look for
> which type of trace to use.

I think it's moot, because we're all in agreement that the code should be deleted. But...

...it is not clear to me that GIT_TRACE_* is dead for further additions. I find it delightfully simple to use, and trace2 often rather baroque and complicated, since it is aimed more at structured data, as well as storing or even transmitting data.

I'm not sure if we have an overall plan there.

-Peff