Re: [PATCH 4alt/4] attr: drop DEBUG_ATTR code

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 6, 2022, 18:52 UTC
Message-ID: <xmqq1qrklr7p.fsf@gitster.g>
In-Reply-To: <fb4cfbd3-e738-f1e8-18f7-d4e90050b8b5@github.com>

Derrick Stolee <derrickstolee@github.com> writes:

Show 11 quoted lines

>> I highly suspect that I was the one who bothered, and while I admit
>> it was useful while developing the attribute subsystem, I haven't
>> needed it for the past 10 or so years.
>> 
>> So unless there are some folks who want to throw everything into the
>> trace2 floodstream, I would prefer this alternative over the other
>> one.
>
> Are you implying that you want to use the second version, that
> deletes the information entirely? I'm leaning towards deleting
> it.

Sorry if I were not clear, but I would vote for using 4alt/4 and remove debugging code. Unless there are folks who want to keep it, in which case I think trace2 is fine and I won't insist on removing what those folks, if any, want to keep. Between trace and trace2, I do not have a strong opinion but if we were adding something new, we would be adding to the latter?

Show 8 quoted lines

> If not, and we should keep using traces, I do notice that the
> original version of the patch uses trace_printf_key() instead
> of a trace2 method. I think this is fine, too, since it's
> likely only to be used by Git developers, who could look for
> which type of trace to use.
>
> Thanks,
> -Stolee