Re: [PATCH v2 3/4] t4113: use "<<-" instead of "<<"

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 2, 2023, 21:05 UTC
Message-ID: <xmqqwn4zsrr2.fsf@gitster.g>
In-Reply-To: <20230202171821.10508-4-cheskaqiqi@gmail.com>

Shuqi Liang <cheskaqiqi@gmail.com> writes:

> use "<<-" instead of "<<"

You forgot to explain "Why?". What you did, anybody can see in the patch text. Why you did so is what you are expected to explain in your proposed log message.

Show 5 quoted lines

> -cat >test-patch <<\EOF
> +cat >test-patch <<-\EOF
>  diff --git a/file b/file
>  --- a/file
>  +++ b/file

There is no need to do this, as the body of the here-doc is not indented/prefixed with HT at all.

Show 9 quoted lines

> @@ -31,7 +31,7 @@ test_expect_success 'apply at the end' '
>  '
>  
>  test_expect_success 'setup for apply at the beginning' '
> -	cat >test-patch <<\EOF
> +	cat >test-patch <<-\EOF
>  	diff a/file b/file
>  	--- a/file
>  	+++ b/file

This is necessary but that is only because [PATCH v2 2/4] broke it. In general, we frown upon a series where a bug is introduced in an earlier step, with another patch fixing that bug.

Let's not introduce such a bug that we need to fix later from the beginning instead.

Thanks.