Re: [PATCH v2 4/4] t4113: indent with tabs

From: Shuqi Liang <cheskaqiqi@gmail.com>
Date: Feb 5, 2023, 14:51 UTC
Message-ID: <CAMO4yUEfcnmfqBEDBxuLfAqwsxOTAOdmOf4L8VDvNq3-6qaFrQ@mail.gmail.com>
In-Reply-To: <xmqqsffnsrik.fsf@gitster.g>

On Thu, Feb 2, 2023 at 4:10 PM Junio C Hamano <gitster@pobox.com> wrote:

> Good, but end the sentence with a full-top with a space after it,
> and start the next sentence with a capital letter.

Sure, think I need to change it to " ...space. Fix..". I will pay more attention to my English written style.

> This is not wrong per se, but the modern style is to avoid having
> any executable lines outside test_expect_foo.  I'd expect that the
> resulting script begins more like the attached.  [PATCH 4/4] stops
> the conversion in the middle, which leaves funny taste in our mouth.

Thanks, Will avoid having any executable lines outside test_expect_foo.

Overall, thanks for the reply and it is really helpful! -------------------------------- Shuqi