Re: [PATCH v3 3/3] t4113: indent with space

From: Shuqi Liang <cheskaqiqi@gmail.com>
Date: Feb 6, 2023, 21:17 UTC
Message-ID: <CAMO4yUFnSQzf9w=gKU6JhaRYbSwhCi_QK1pAQbOuaTa8uEiEog@mail.gmail.com>
In-Reply-To: <CAPig+cTH_5Bu48fO1Eub25CLZmRCmz4EjYz9O++H12HGTVXU0w@mail.gmail.com>

Hi, Eric

On Sun, Feb 5, 2023 at 3:30 PM Eric Sunshine <sunshine@sunshineco.com> wrote:

> This probably ought to say "indent with tab" since that's what this
> patch is doing.

Thanks ,I will fix it .

Show 5 quoted lines

> If you do find a reason to re-roll, though, I might suggest swapping
> patches 2 and 3 since the current organization leaves a mix of tab and
> space indentation in the tests, which makes reviewers do extra work
> since they have to look ahead in the patch series to see if you fix
> the inconsistent indentation in a later patch.

Yeah ,I didn‘t realize that .Thanks for reply! I will send the V4 soon. ---------- Thanks, Shuqi

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.