Re: [PATCH 0/4] commit-graph: avoid looking at Bloom filter data directly

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 19, 2023, 19:24 UTC
Message-ID: <xmqqwmyvaemr.fsf@gitster.g>
In-Reply-To: <cover.1689789226.git.me@ttaylorr.com>

Taylor Blau <me@ttaylorr.com> writes:

Show 6 quoted lines

> The first three are preparatory, but the fourth patch should allow us to
> drop the Perl hackery necessary to dump the raw contents of arbitrary
> Bloom filters.
>
> Feel free to pick up these patches (or not), just wanted to get these
> out there as a possible suggestion.

Thanks, these seem like a good thing to do. Would love to see an updated version with them rolled in.

Thanks both for working so well together.

Show 15 quoted lines

>
> Taylor Blau (4):
>   t/helper/test-read-graph.c: extract `dump_graph_info()`
>   bloom.h: make `load_bloom_filter_from_graph()` public
>   t/helper/test-read-graph: implement `bloom-filters` mode
>   fixup! t4216: test changed path filters with high bit paths
>
>  bloom.c                    |  6 ++--
>  bloom.h                    |  5 +++
>  t/helper/test-read-graph.c | 67 ++++++++++++++++++++++++++++++--------
>  t/t4216-log-bloom.sh       | 14 ++------
>  4 files changed, 64 insertions(+), 28 deletions(-)
>
> --
> 2.41.0.366.g215419bf3c2.dirty