Re: [PATCH v5 3/4] repo-settings: introduce commitgraph.changedPathsVersion
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Jul 20, 2023, 21:02 UTC
- Message-ID
- <ZLmg/58O9EsHi7Rn@nand.local>
- In-Reply-To
- <20230720204232.1328482-1-jonathantanmy@google.com>
On Thu, Jul 20, 2023 at 01:42:32PM -0700, Jonathan Tan wrote:
Show 13 quoted lines
> > > - if (s->commit_graph_read_changed_paths) {
> > > + if (s->commit_graph_changed_paths_version != 0) {
> > > pair_chunk(cf, GRAPH_CHUNKID_BLOOMINDEXES,
> > > &graph->chunk_bloom_indexes);
> > > read_chunk(cf, GRAPH_CHUNKID_BLOOMDATA,
> >
> > Just a small note, but writing this as
> >
> > if (!s->commit_graph_changed_paths_version)
> >
> > would probably be more in line with our coding guidelines.
>
> Ah, yes. Changed it (without the exclamation mark).Hah, whoops -- thanks for spotting my mistake there. :-)
Thanks, Taylor