Re: [PATCH v6 5/7] t4216: test changed path filters with high bit paths

From: Taylor Blau <me@ttaylorr.com>
Date: Jul 26, 2023, 23:28 UTC
Message-ID: <ZMGsJTxBXZ94lhMU@nand.local>
In-Reply-To: <5276e6a90ecb84cbca3b14a27dc055cf81d27ac3.1689889382.git.jonathantanmy@google.com>

On Thu, Jul 20, 2023 at 02:46:38PM -0700, Jonathan Tan wrote:

Show 6 quoted lines

> +test_expect_success 'setup check value of version 1 changed-path' '
> +	(cd highbit1 &&
> +		echo "52a9" >expect &&
> +		get_first_changed_path_filter >actual &&
> +		test_cmp expect actual)
> +'

This is a little bit of funky indentation, I probably would have expected something more along the lines of:

    (
      cd highbit1 &&
      echo "52a9" >expect &&
      get_first_changed_path_filter >actual &&
      test_cmp expect actual
    )

but this obviously doesn't merit a reroll on its own.

> +test_expect_success 'version 1 changed-path used when version 1 requested' '
> +	(cd highbit1 &&
> +		test_bloom_filters_used "-- $CENT")
> +'

Same here, but neither of these is incorrect.

Thanks, Taylor