Re: [PATCH v2 8/8] trailer: retire trailer_info_get() from API
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 23, 2024, 23:27 UTC
- Message-ID
- <xmqqwmon4q3z.fsf@gitster.g>
- In-Reply-To
- <eca77a1a462a624f988fc50f7588d831678f34f4.1713504153.git.gitgitgadget@gmail.com>
"Linus Arver via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 5 quoted lines
> From: Linus Arver <linusa@google.com> > > Make trailer_info_get() "static" to be file-scoped to trailer.c, because > no one outside of trailer.c uses it. Remove its declaration from > <trailer.h>.
Yay. But the callers still need to know what parse_trailers() gives them, and what they can do with the struct.
Other than that, an obvious last step that concludes the series. Nicely structured.