Re: [PATCH v3 00/10] Make trailer_info struct private (plus sequencer cleanup)

From: Christian Couder <christian.couder@gmail.com>
Date: Apr 27, 2024, 12:51 UTC
Message-ID: <CAP8UFD3Vzs2KvsE2qmx_54UX9ktAngr2FkpKfWVjRMD=t1B7Wg@mail.gmail.com>
In-Reply-To: <pull.1696.v3.git.1714091170.gitgitgadget@gmail.com>

(I had sent this email only to Linus too, sorry.)

On Fri, Apr 26, 2024 at 2:26 AM Linus Arver via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 11 quoted lines

> Linus Arver (10):
>   Makefile: sort UNIT_TEST_PROGRAMS
>   trailer: add unit tests for trailer iterator
>   trailer: teach iterator about non-trailer lines
>   sequencer: use the trailer iterator
>   interpret-trailers: access trailer_info with new helpers
>   trailer: make parse_trailers() return trailer_info pointer
>   trailer: make trailer_info struct private
>   trailer: retire trailer_info_get() from API
>   trailer: document parse_trailers() usage
>   trailer unit tests: inspect iterator contents

I took a look at the whole series and had only a few minor comments on some patches.

Thanks!