Re: [PATCH v3] pack-bitmap: remove checks before bitmap_free

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 3, 2025, 15:14 UTC
Message-ID: <xmqqwm9sq2lq.fsf@gitster.g>
In-Reply-To: <0BFD6581-2BB9-439B-9837-767FA98900C5@smail.nju.edu.cn>

lidongyan <502024330056@smail.nju.edu.cn> writes:

Show 7 quoted lines

>> And if the test passed without exporting the variable, is it really
>> testing what we want to test?
>> 
>
> Sorry about that. I should put GIT_TEST_PACK_USE_BITMAP_BOUNDARY_TRAVERSAL
> In front of `git rev-list …` so that when traverse bitmap it
> enters `pack-bitmap:find_boundary_objects()`.

That would work well. By narrowing where the environment variable is applied, such an arrangement would also help readers.

It still is curious why this version did not fail for you, though. If setting it without exporting it still made "rev-list" traverse and expected result, wouldn't that mean we are not really testing what we want to test?

Show 14 quoted lines

>>> + test_commit A &&
>>> + git repack -adb &&
>>> + test_commit B &&
>>> +
>>> + echo '1' >expect &&
>>> + git rev-list --count --use-bitmap-index HEAD~1..HEAD >actual &&
>>> + test_cmp expect actual
>>> + )
>>> +'
>>> +
>>> test_done
>>> 
>>> base-commit: 845c48a16a7f7b2c44d8cb137b16a4a1f0140229
>>