Re: [PATCH v3] pack-bitmap: remove checks before bitmap_free

From: lidongyan <502024330056@smail.nju.edu.cn>
Date: Jun 3, 2025, 06:22 UTC
Message-ID: <0BFD6581-2BB9-439B-9837-767FA98900C5@smail.nju.edu.cn>
In-Reply-To: <xmqq1ps1s698.fsf@gitster.g>

2025年6月3日 14:12，Junio C Hamano <gitster@pobox.com> 写道：

Show 24 quoted lines

> 
> "Lidong Yan via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> +test_expect_success 'use pseudo-merge in boundary traversal' '
>> + git init pseudo-merge-boundary-traversal &&
>> + (
>> + cd pseudo-merge-boundary-traversal &&
>> +
>> + git config bitmapPseudoMerge.test.pattern refs/ &&
>> + git config bitmapPseudoMerge.test.threshold now &&
>> + git config bitmapPseudoMerge.test.stableThreshold now &&
> 
> 
>> + GIT_TEST_PACK_USE_BITMAP_BOUNDARY_TRAVERSAL=1 &&
> 
> Either before or after that line, don't you need to 
> 
> export GIT_TEST_PACK_USE_BITMAP_BOUNDARY_TRAVERSAL &&
> 
> as well?
> 
> And if the test passed without exporting the variable, is it really
> testing what we want to test?
>

Sorry about that. I should put GIT_TEST_PACK_USE_BITMAP_BOUNDARY_TRAVERSAL In front of `git rev-list …` so that when traverse bitmap it enters `pack-bitmap:find_boundary_objects()`.

Show 14 quoted lines

>> + test_commit A &&
>> + git repack -adb &&
>> + test_commit B &&
>> +
>> + echo '1' >expect &&
>> + git rev-list --count --use-bitmap-index HEAD~1..HEAD >actual &&
>> + test_cmp expect actual
>> + )
>> +'
>> +
>> test_done
>> 
>> base-commit: 845c48a16a7f7b2c44d8cb137b16a4a1f0140229
>