Re: [PATCH v6] pack-bitmap: remove checks before bitmap_free

From: lidongyan <502024330056@smail.nju.edu.cn>
Date: Jun 6, 2025, 05:49 UTC
Message-ID: <E2C28248-2486-4E2A-846E-1C6233E7CE6A@smail.nju.edu.cn>
In-Reply-To: <xmqqplfh64lc.fsf@gitster.g>

2025年6月6日 09:28，Junio C Hamano <gitster@pobox.com> 写道：

Show 14 quoted lines

> 
> "Lidong Yan via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> From: Lidong Yan <502024330056@smail.nju.edu.cn>
>> 
>> In pack-bitmap.c:find_boundary_objects(), the roots_bitmap is only freed
>> if cascade_pseudo_merges_1() fails. Since cascade_pseudo_merges_1() only
>> use roots_bitmap as a mutable reference but not takes roots_bitmap's
>> ownership.
> 
> Sorry but I cannot parse the last sentence above.  I would have
> expected that "Since/Because X" to be followed by comma and a
> sentence that describes the consequence of X.  Also "but not takes"
> -> "but does not take", probably.

You are right, I should use a grammar checker (chatgpt) on my log message. How about “ Since cascade_pseudo_merges_1() only use roots_bitmap as a mutable reference but not takes roots_bitmap's ownership. Once cascade_pseudo_merges_1() succeeds, roots_bitmap leaks. ” -> “ However, cascade_pseudo_merges_1() uses roots_bitmap as a mutable reference without taking ownership of it. As a result, if cascade_pseudo_merges_1() succeeds, roots_bitmap is leaked. ”