git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 11/12] builtin/gc: fix signedness issues in ODB-related functionality

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 26, 2026, 16:25 UTC
Message-ID
<xmqqwluhvhtu.fsf@gitster.g>
In-Reply-To
<amCmwKjbq2aNt8mZ@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 26 quoted lines
> On Mon, Jul 13, 2026 at 09:28:02AM -0700, Junio C Hamano wrote:
>> Patrick Steinhardt <ps@pks.im> writes:
>> > diff --git a/builtin/gc.c b/builtin/gc.c
>> > index 3207182488..8cf3781313 100644
>> > --- a/builtin/gc.c
>> > @@ -456,7 +458,7 @@ static struct packed_git *find_base_packs(struct odb_source_files *files,
>> >  		if (e->pack->is_cruft)
>> >  			continue;
>> >  		if (limit) {
>> > -			if (e->pack->pack_size >= limit)
>> > +			if ((uintmax_t) e->pack->pack_size >= limit)
>> 
>> Here, just like in too_many_loose_objects(), 'limit' is of type
>> 'unsigned long'.  While it makes sense to convert both sides of
>> the comparison to an unsigned type, casting only the left side
>> to a type that differs from the right side puzzles me.
>> 
>> Presumably, the other side is of type 'off_t', which is signed,
>> explaining the desire to cast it to an unsigned type.  But I am
>> not sure what happens if 'off_t' is wider than 'unsigned long'.
>
> Yeah, `pack_size` is an `off_t`, which is signed. But we never populate
> it with a negative value, so casting it to `uintmax_t` in unnecessary.
> The right-hand side is already unsigned, so due to the usual arithmetic
> conversion rules it would be automatically promoted to `uintmax_t`, as
> well.

So we are in agreement that this hunk, unlike others, have little to do with "fix signedness issues"?

I personally feel that the true fix in signedness issues is not to use -Wsign-compare or teach compilers to be intelligent about when to issue the warning when given that flag, but that is a separate topic.

Thanks.
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 31 of 33 in “odb: make optimizations pluggable”
  1. 00/11 odb: make optimizations pluggablePatrick Steinhardt, Jul 7, 2026
  2. 01/11 odb: run "pre-auto-gc" hook for all maintenance tasksPatrick Steinhardt, Jul 7, 2026
  3. Junio C HamanoJul 7, 2026
  4. Patrick SteinhardtJul 8, 2026
  5. 02/11 builtin/gc: move worktree and rerere tasks before object optimizationsPatrick Steinhardt, Jul 7, 2026
  6. Junio C HamanoJul 7, 2026
  7. 03/11 builtin/gc: extract object database optimizations into separate functionPatrick Steinhardt, Jul 7, 2026
  8. Junio C HamanoJul 7, 2026
  9. 04/11 builtin/gc: make repack arguments self-containedPatrick Steinhardt, Jul 7, 2026
  10. 05/11 builtin/gc: inline config values specific to the "files" backendPatrick Steinhardt, Jul 7, 2026
  11. 06/11 builtin/gc: introduce object database optimization optionsPatrick Steinhardt, Jul 7, 2026
  12. 07/11 builtin/gc: move geometric repacking into `odb_optimize()`Patrick Steinhardt, Jul 7, 2026
  13. 08/11 builtin/gc: introduce `odb_optimize_required()`Patrick Steinhardt, Jul 7, 2026
  14. 09/11 builtin/gc: refactor ODB optimizations to operate on "files" sourcePatrick Steinhardt, Jul 7, 2026
  15. 10/11 builtin/gc: fix signedness issues in ODB-related functionalityPatrick Steinhardt, Jul 7, 2026
  16. 11/11 odb: make optimizations pluggablePatrick Steinhardt, Jul 7, 2026
  17. 00/12 odb: make optimizations pluggablePatrick Steinhardt, Jul 13, 2026
  18. 01/12 t7900: simplify how we check for maintenance tasksPatrick Steinhardt, Jul 13, 2026
  19. 02/12 odb: run "pre-auto-gc" hook for all maintenance tasksPatrick Steinhardt, Jul 13, 2026
  20. 03/12 builtin/gc: move worktree and rerere tasks before object optimizationsPatrick Steinhardt, Jul 13, 2026
  21. 04/12 builtin/gc: extract object database optimizations into separate functionPatrick Steinhardt, Jul 13, 2026
  22. 05/12 builtin/gc: make repack arguments self-containedPatrick Steinhardt, Jul 13, 2026
  23. 06/12 builtin/gc: inline config values specific to the "files" backendPatrick Steinhardt, Jul 13, 2026
  24. 07/12 builtin/gc: introduce object database optimization optionsPatrick Steinhardt, Jul 13, 2026
  25. 08/12 builtin/gc: move geometric repacking into `odb_optimize()`Patrick Steinhardt, Jul 13, 2026
  26. 09/12 builtin/gc: introduce `odb_optimize_required()`Patrick Steinhardt, Jul 13, 2026
  27. 10/12 builtin/gc: refactor ODB optimizations to operate on "files" sourcePatrick Steinhardt, Jul 13, 2026
  28. 11/12 builtin/gc: fix signedness issues in ODB-related functionalityPatrick Steinhardt, Jul 13, 2026
  29. Junio C HamanoJul 13, 2026
  30. Patrick SteinhardtJul 22, 2026
  31. Junio C HamanoJul 26, 2026
  32. 12/12 odb: make optimizations pluggablePatrick Steinhardt, Jul 13, 2026
  33. Junio C HamanoJul 13, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.