git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 12/12] odb: make optimizations pluggable

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 13, 2026, 16:34 UTC
Message-ID
<xmqqh5m2yhkm.fsf@gitster.g>
In-Reply-To
<20260713-b4-pks-odb-optimize-v2-12-9c2c3ee94b38@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 11 quoted lines
> Move `odb_optimize()` and `odb_optimize_required()` from "builtin/gc.c"
> into the "files" source and wire them up via newly introduced vtable
> pointers for the object database sources. This makes the logic pluggable
> and thus allows other backends to have their own, custom implementation.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  builtin/gc.c       | 490 +----------------------------------------------------
>  odb.c              |  12 ++
>  odb.h              |  45 +++++
>  odb/source-files.c | 470 ++++++++++++++++++++++++++++++++++++++++++++++++++

Reviewing this commit with "git show --color-moved" is an excellent way to verify that this is 90% pure code motion. Only minimal adjustments were required, such as replacing a direct reference to a struct member in the original with a variable that was previously assigned the equivalent value.

For example, this original
Show 12 quoted lines
> -	switch (opts->strategy) {
> -	case ODB_OPTIMIZE_INCREMENTAL: {
> -		int gc_auto_threshold = 6700;
> -		int gc_auto_pack_limit = 50;
> -
> -		repo_config_get_int(odb->repo, "gc.auto", &gc_auto_threshold);
> -		repo_config_get_int(odb->repo, "gc.autopacklimit", &gc_auto_pack_limit);
> -
> -		/*
> -		 * Setting gc.auto to 0 or negative can disable the
> -		 * automatic gc.
> -		 */
turns into
Show 12 quoted lines
> +	switch (opts->strategy) {
> +	case ODB_OPTIMIZE_INCREMENTAL: {
> +		int gc_auto_threshold = 6700;
> +		int gc_auto_pack_limit = 50;
> +
> +		repo_config_get_int(repo, "gc.auto", &gc_auto_threshold);
> +		repo_config_get_int(repo, "gc.autopacklimit", &gc_auto_pack_limit);
> +
> +		/*
> +		 * Setting gc.auto to 0 or negative can disable the
> +		 * automatic gc.
> +		 */
And the change from odb->repo vs repo is such an adjustment.
Looking good.
Previous: Patrick Steinhardt
Message 33 of 33 in “odb: make optimizations pluggable”
  1. 00/11 odb: make optimizations pluggablePatrick Steinhardt, Jul 7, 2026
  2. 01/11 odb: run "pre-auto-gc" hook for all maintenance tasksPatrick Steinhardt, Jul 7, 2026
  3. Junio C HamanoJul 7, 2026
  4. Patrick SteinhardtJul 8, 2026
  5. 02/11 builtin/gc: move worktree and rerere tasks before object optimizationsPatrick Steinhardt, Jul 7, 2026
  6. Junio C HamanoJul 7, 2026
  7. 03/11 builtin/gc: extract object database optimizations into separate functionPatrick Steinhardt, Jul 7, 2026
  8. Junio C HamanoJul 7, 2026
  9. 04/11 builtin/gc: make repack arguments self-containedPatrick Steinhardt, Jul 7, 2026
  10. 05/11 builtin/gc: inline config values specific to the "files" backendPatrick Steinhardt, Jul 7, 2026
  11. 06/11 builtin/gc: introduce object database optimization optionsPatrick Steinhardt, Jul 7, 2026
  12. 07/11 builtin/gc: move geometric repacking into `odb_optimize()`Patrick Steinhardt, Jul 7, 2026
  13. 08/11 builtin/gc: introduce `odb_optimize_required()`Patrick Steinhardt, Jul 7, 2026
  14. 09/11 builtin/gc: refactor ODB optimizations to operate on "files" sourcePatrick Steinhardt, Jul 7, 2026
  15. 10/11 builtin/gc: fix signedness issues in ODB-related functionalityPatrick Steinhardt, Jul 7, 2026
  16. 11/11 odb: make optimizations pluggablePatrick Steinhardt, Jul 7, 2026
  17. 00/12 odb: make optimizations pluggablePatrick Steinhardt, Jul 13, 2026
  18. 01/12 t7900: simplify how we check for maintenance tasksPatrick Steinhardt, Jul 13, 2026
  19. 02/12 odb: run "pre-auto-gc" hook for all maintenance tasksPatrick Steinhardt, Jul 13, 2026
  20. 03/12 builtin/gc: move worktree and rerere tasks before object optimizationsPatrick Steinhardt, Jul 13, 2026
  21. 04/12 builtin/gc: extract object database optimizations into separate functionPatrick Steinhardt, Jul 13, 2026
  22. 05/12 builtin/gc: make repack arguments self-containedPatrick Steinhardt, Jul 13, 2026
  23. 06/12 builtin/gc: inline config values specific to the "files" backendPatrick Steinhardt, Jul 13, 2026
  24. 07/12 builtin/gc: introduce object database optimization optionsPatrick Steinhardt, Jul 13, 2026
  25. 08/12 builtin/gc: move geometric repacking into `odb_optimize()`Patrick Steinhardt, Jul 13, 2026
  26. 09/12 builtin/gc: introduce `odb_optimize_required()`Patrick Steinhardt, Jul 13, 2026
  27. 10/12 builtin/gc: refactor ODB optimizations to operate on "files" sourcePatrick Steinhardt, Jul 13, 2026
  28. 11/12 builtin/gc: fix signedness issues in ODB-related functionalityPatrick Steinhardt, Jul 13, 2026
  29. Junio C HamanoJul 13, 2026
  30. Patrick SteinhardtJul 22, 2026
  31. Junio C HamanoJul 26, 2026
  32. 12/12 odb: make optimizations pluggablePatrick Steinhardt, Jul 13, 2026
  33. Junio C HamanoJul 13, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.