git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 01/11] odb: run "pre-auto-gc" hook for all maintenance tasks

From
Patrick Steinhardt <ps@pks.im>
Date
Jul 8, 2026, 07:55 UTC
Message-ID
<ak4CHGpIhVIT9sd2@pks.im>
In-Reply-To
<xmqqo6gi1sng.fsf@gitster.g>
On Tue, Jul 07, 2026 at 12:55:31PM -0700, Junio C Hamano wrote:
Show 44 quoted lines
> Patrick Steinhardt <ps@pks.im> writes:
> > diff --git a/t/t7900-maintenance.sh b/t/t7900-maintenance.sh
> > index d7f82e1bec..1212b306b6 100755
> > --- a/t/t7900-maintenance.sh
> > +++ b/t/t7900-maintenance.sh
> > @@ -740,6 +740,127 @@ test_expect_success 'geometric repacking honors configured split factor' '
> >  	)
> >  '
> >  
> > +test_expect_success 'pre-auto-gc hook runs exactly once' '
> > +	test_when_finished "rm -rf repo" &&
> > +	git init repo &&
> > +	(
> > +		cd repo &&
> > +		write_script .git/hooks/pre-auto-gc <<-\EOF &&
> > +		echo hook >>hook.log
> > +		EOF
> > +
> > +		# Satisfy the auto condition for multiple tasks, both in the
> > +		# foreground and in the background phase.
> > +		git config set maintenance.reflog-expire.auto -1 &&
> > +		git config set maintenance.geometric-repack.auto -1 &&
> > +		git config set maintenance.rerere-gc.auto -1 &&
> > +
> > +		GIT_TRACE2_EVENT="$(pwd)/trace2.txt" \
> > +			git maintenance run --auto 2>/dev/null &&
> > +
> > +		# The successful hook does not inhibit any of the tasks...
> > +		test_subcommand git reflog expire --all <trace2.txt &&
> > +		test_subcommand_flex git repack <trace2.txt &&
> > +		test_subcommand git rerere gc <trace2.txt &&
> > +		# ... but it must only have been executed a single time.
> > +		test_line_count = 1 hook.log
> > +	)
> > +'
> 
> Somehow I'd feel better if the hook used a full path to the append
> only log file, but it is reasonably clear that these three commands
> are unlikely to chdir around, so it may be OK.
> 
> Obviously not in scope of this topic, but I wonder if we have a
> better way to test these three "housekeeping tasks" have run, than
> casting in stone the current implementation that spawns these three
> external command as subprocesses.

Yeah, this is awfully fragile indeed. Since 25914c4fde (maintenance: add trace2 regions for task execution, 2020-09-17) we already have trace2 markers for each task that's running, so that may indeed be a much better way to figure out whether the task is running or not.

I've made some local changes, but will hold back with sending a v2 until there's more feedback.

Thanks!
Patrick
Previous: Junio C HamanoNext: Patrick Steinhardt
Message 4 of 33 in “odb: make optimizations pluggable”
  1. 00/11 odb: make optimizations pluggablePatrick Steinhardt, Jul 7, 2026
  2. 01/11 odb: run "pre-auto-gc" hook for all maintenance tasksPatrick Steinhardt, Jul 7, 2026
  3. Junio C HamanoJul 7, 2026
  4. Patrick SteinhardtJul 8, 2026
  5. 02/11 builtin/gc: move worktree and rerere tasks before object optimizationsPatrick Steinhardt, Jul 7, 2026
  6. Junio C HamanoJul 7, 2026
  7. 03/11 builtin/gc: extract object database optimizations into separate functionPatrick Steinhardt, Jul 7, 2026
  8. Junio C HamanoJul 7, 2026
  9. 04/11 builtin/gc: make repack arguments self-containedPatrick Steinhardt, Jul 7, 2026
  10. 05/11 builtin/gc: inline config values specific to the "files" backendPatrick Steinhardt, Jul 7, 2026
  11. 06/11 builtin/gc: introduce object database optimization optionsPatrick Steinhardt, Jul 7, 2026
  12. 07/11 builtin/gc: move geometric repacking into `odb_optimize()`Patrick Steinhardt, Jul 7, 2026
  13. 08/11 builtin/gc: introduce `odb_optimize_required()`Patrick Steinhardt, Jul 7, 2026
  14. 09/11 builtin/gc: refactor ODB optimizations to operate on "files" sourcePatrick Steinhardt, Jul 7, 2026
  15. 10/11 builtin/gc: fix signedness issues in ODB-related functionalityPatrick Steinhardt, Jul 7, 2026
  16. 11/11 odb: make optimizations pluggablePatrick Steinhardt, Jul 7, 2026
  17. 00/12 odb: make optimizations pluggablePatrick Steinhardt, Jul 13, 2026
  18. 01/12 t7900: simplify how we check for maintenance tasksPatrick Steinhardt, Jul 13, 2026
  19. 02/12 odb: run "pre-auto-gc" hook for all maintenance tasksPatrick Steinhardt, Jul 13, 2026
  20. 03/12 builtin/gc: move worktree and rerere tasks before object optimizationsPatrick Steinhardt, Jul 13, 2026
  21. 04/12 builtin/gc: extract object database optimizations into separate functionPatrick Steinhardt, Jul 13, 2026
  22. 05/12 builtin/gc: make repack arguments self-containedPatrick Steinhardt, Jul 13, 2026
  23. 06/12 builtin/gc: inline config values specific to the "files" backendPatrick Steinhardt, Jul 13, 2026
  24. 07/12 builtin/gc: introduce object database optimization optionsPatrick Steinhardt, Jul 13, 2026
  25. 08/12 builtin/gc: move geometric repacking into `odb_optimize()`Patrick Steinhardt, Jul 13, 2026
  26. 09/12 builtin/gc: introduce `odb_optimize_required()`Patrick Steinhardt, Jul 13, 2026
  27. 10/12 builtin/gc: refactor ODB optimizations to operate on "files" sourcePatrick Steinhardt, Jul 13, 2026
  28. 11/12 builtin/gc: fix signedness issues in ODB-related functionalityPatrick Steinhardt, Jul 13, 2026
  29. Junio C HamanoJul 13, 2026
  30. Patrick SteinhardtJul 22, 2026
  31. Junio C HamanoJul 26, 2026
  32. 12/12 odb: make optimizations pluggablePatrick Steinhardt, Jul 13, 2026
  33. Junio C HamanoJul 13, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.