Re: netrc credential helper promotion out of contrib?
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 20, 2013, 19:28 UTC
- Message-ID
- <xmqqvc305fh4.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <87k3jjp9q5.fsf@lifelogs.com>
Ted Zlatanov <tzz@lifelogs.com> writes:
> A while has passed since contrib/credential/netrc was added. Is it OK to > promote it to be part of the main installation?
I gave it a quick glance, and it seems to be cleanly written, except that "EOHIPPUS" (End-of-Hippus? Eohippus the extinct horse?) looked a bit too strange to my taste ;-). It does not seem to use features older versions of Perl some people are stuck with do not support.
I do not mind seeing a patch that moves contrib/credential/netrc to credential/netrc and adjusts the top-level Makefile. The test script needs to be updated to fit the rest of t/ hierarchy better, though.