netrc credential helper promotion out of contrib?

A while has passed since contrib/credential/netrc was added. Is it OK to promote it to be part of the main installation? In that directory there's also gnome-keyring, osxkeychain, and wincred; I don't know if those are ready for promotion.

Thanks Ted

Ted Zlatanov <tzz@lifelogs.com> writes:

I gave it a quick glance, and it seems to be cleanly written, except that "EOHIPPUS" (End-of-Hippus? Eohippus the extinct horse?) looked a bit too strange to my taste ;-). It does not seem to use features older versions of Perl some people are stuck with do not support.

I do not mind seeing a patch that moves contrib/credential/netrc to credential/netrc and adjusts the top-level Makefile. The test script needs to be updated to fit the rest of t/ hierarchy better, though.

On Tue, 20 Aug 2013 12:28:39 -0700 Junio C Hamano <gitster@pobox.com> wrote: 

JCH> Ted Zlatanov <tzz@lifelogs.com> writes:

JCH> I gave it a quick glance, and it seems to be cleanly written, except JCH> that "EOHIPPUS" (End-of-Hippus? Eohippus the extinct horse?) looked JCH> a bit too strange to my taste ;-). It does not seem to use features JCH> older versions of Perl some people are stuck with do not support.

Thanks, I was careful about that. `EOF' as the end-of-document marker is a bit boring, don't you think? Well, I can use it here if you insist, but it seems OK to me.

JCH> I do not mind seeing a patch that moves contrib/credential/netrc to JCH> credential/netrc and adjusts the top-level Makefile. The test JCH> script needs to be updated to fit the rest of t/ hierarchy better, JCH> though.

OK, I will work on that patch.  Thanks for the reply.

Ted