Re: netrc credential helper promotion out of contrib?
- From
Ted Zlatanov <tzz@lifelogs.com>
- Date
- Sep 3, 2013, 15:12 UTC
- Message-ID
- <87ob8ahrco.fsf@lifelogs.com>
- In-Reply-To
- <xmqqvc305fh4.fsf@gitster.dls.corp.google.com>
On Tue, 20 Aug 2013 12:28:39 -0700 Junio C Hamano <gitster@pobox.com> wrote:
JCH> Ted Zlatanov <tzz@lifelogs.com> writes:
>> A while has passed since contrib/credential/netrc was added. Is it OK to >> promote it to be part of the main installation?
JCH> I gave it a quick glance, and it seems to be cleanly written, except JCH> that "EOHIPPUS" (End-of-Hippus? Eohippus the extinct horse?) looked JCH> a bit too strange to my taste ;-). It does not seem to use features JCH> older versions of Perl some people are stuck with do not support.
Thanks, I was careful about that. `EOF' as the end-of-document marker is a bit boring, don't you think? Well, I can use it here if you insist, but it seems OK to me.
JCH> I do not mind seeing a patch that moves contrib/credential/netrc to JCH> credential/netrc and adjusts the top-level Makefile. The test JCH> script needs to be updated to fit the rest of t/ hierarchy better, JCH> though.
OK, I will work on that patch. Thanks for the reply.
Ted