Re: [PATCH 1/2] t0003: do not chdir the whole test process

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 6, 2014, 20:25 UTC
Message-ID: <xmqqvbwsxa2b.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140206194521.GU30398@google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 14 quoted lines

> Junio C Hamano wrote:
>
>> Moving to some other directory and letting the remainder of the test
>> pieces to expect that they start there is a bad practice.
>
> I agree with the above, and I like the patch...
>
>>                                                            The test
>> that contains chdir itself may fail (or by mistake skipped via the
>> GIT_SKIP_TESTS mechanism) in which case the remainder may operate on
>> files in unexpected places.
>
> ... but this logic seems wrong.  I don't think we've ever supported
> setup tests failing or being skipped in the past.

The first set-up test, yes, but something in the middle added as an afterthought?