Re: [PATCH 2/2] check-attr: move to the top of working tree when in non-bare repository

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Feb 6, 2014, 19:53 UTC
Message-ID: <20140206195310.GV30398@google.com>
In-Reply-To: <1391712033-9443-2-git-send-email-gitster@pobox.com>

Hi,

Junio C Hamano wrote:

Show 8 quoted lines

> --- a/builtin/check-attr.c
> +++ b/builtin/check-attr.c
> @@ -94,6 +94,9 @@ int cmd_check_attr(int argc, const char **argv, const char *prefix)
>  	struct git_attr_check *check;
>  	int cnt, i, doubledash, filei;
>  
> +	if (!is_bare_repository())
> +		setup_work_tree();

Hm. Shouldn't check-attr error out when run without a worktree and without --cached?

That would mean something like

diff --git i/builtin/check-attr.c w/builtin/check-attr.c
index e9af7b2..c34b6ee 100644
--- i/builtin/check-attr.c
+++ w/builtin/check-attr.c
@@ -107,6 +107,9 @@ int cmd_check_attr(int argc, const char **argv, const char *prefix)
 	argc = parse_options(argc, argv, prefix, check_attr_options,
 			     check_attr_usage, PARSE_OPT_KEEP_DASHDASH);
 
+	if (!cached_attrs)
+		setup_work_tree();
+
 	if (read_cache() < 0) {
 		die("invalid cache");
 	}