git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] t0003: do not chdir the whole test process

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Feb 6, 2014, 19:45 UTC
Message-ID
<20140206194521.GU30398@google.com>
In-Reply-To
<1391712033-9443-1-git-send-email-gitster@pobox.com>
Junio C Hamano wrote:
> Moving to some other directory and letting the remainder of the test
> pieces to expect that they start there is a bad practice.
I agree with the above, and I like the patch...
>                                                            The test
> that contains chdir itself may fail (or by mistake skipped via the
> GIT_SKIP_TESTS mechanism) in which case the remainder may operate on
> files in unexpected places.

... but this logic seems wrong. I don't think we've ever supported setup tests failing or being skipped in the past.

Thanks, Jonathan

Previous: Michael HaggertyNext: Junio C Hamano
Message 9 of 13 in “attr.c doesn't honor --work-tree option”
  1. Lasse MakholmFeb 6, 2014
  2. Junio C HamanoFeb 6, 2014
  3. 1/2 t0003: do not chdir the whole test processJunio C Hamano, Feb 6, 2014
  4. 2/2 check-attr: move to the top of working tree when in non-bare repositoryJunio C Hamano, Feb 6, 2014
  5. Jonathan NiederFeb 6, 2014
  6. Jonathan NiederFeb 6, 2014
  7. Junio C HamanoFeb 6, 2014
  8. Michael HaggertyFeb 16, 2014
  9. Jonathan NiederFeb 6, 2014
  10. Junio C HamanoFeb 6, 2014
  11. Jonathan NiederFeb 6, 2014
  12. Junio C HamanoFeb 6, 2014
  13. Lasse MakholmFeb 10, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.