Re: [PATCH 11/22] lockfile: define a constant LOCK_SUFFIX_LEN
Michael Haggerty <mhagger@alum.mit.edu> writes:
Show 27 quoted lines
> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
> ---
> lockfile.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/lockfile.c b/lockfile.c
> index 4a9ceda..4e3ada8 100644
> --- a/lockfile.c
> +++ b/lockfile.c
> @@ -178,14 +178,17 @@ static char *resolve_symlink(char *p, size_t s)
> return p;
> }
>
> +/* We append ".lock" to the filename to derive the lockfile name: */
> +#define LOCK_SUFFIX_LEN 5
>
> static int lock_file(struct lock_file *lk, const char *path, int flags)
> {
> /*
> - * subtract 5 from size to make sure there's room for adding
> - * ".lock" for the lock file name
> + * subtract LOCK_SUFFIX_LEN from size to make sure there's
> + * room for adding ".lock" for the lock file name:
> */
> - static const size_t max_path_len = sizeof(lk->filename) - 5;
> + static const size_t max_path_len = sizeof(lk->filename) -
> + LOCK_SUFFIX_LEN;SP{8,} in the indent; I've cleaned it up while queueing.Thanks.