Re: [PATCH] git grep -O -i: if the pager is 'less', pass the '-i' option
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 12 quoted lines
>>> + if (opt.ignore_case && !strcmp("less", pager))
>>> + string_list_append(&path_list, "-i");
>>
>> I have a feeling that this goes against the recent trend of not
>> mucking with the expectation of the users on their pagers, if I
>> recall correctly the arguments for dropping S from the default given
>> to an unconfigured LESS environment variable.
>
> It's just missing an explanation.
> ...
> (That's -I, not -i, because it ought to work even when the pattern
> contains capital letters.)Spot on. The change, especially with "-I", makes sense.
Thanks.