git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git grep -O -i: if the pager is 'less', pass the '-i' option

From
Junio C Hamano <gitster@pobox.com>
Date
May 14, 2014, 18:33 UTC
Message-ID
<xmqqvbt8jjlg.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20140514182654.GA9218@google.com>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 12 quoted lines
>>> +		if (opt.ignore_case && !strcmp("less", pager))
>>> +			string_list_append(&path_list, "-i");
>>
>> I have a feeling that this goes against the recent trend of not
>> mucking with the expectation of the users on their pagers, if I
>> recall correctly the arguments for dropping S from the default given
>> to an unconfigured LESS environment variable.
>
> It's just missing an explanation.
> ...
> (That's -I, not -i, because it ought to work even when the pattern
> contains capital letters.)
Spot on.  The change, especially with "-I", makes sense.
Thanks.
Previous: Jonathan NiederNext: Johannes Schindelin
Message 5 of 14 in “git grep -O -i: if the pager is 'less', pass the '-i' option”
  1. git grep -O -i: if the pager is 'less', pass the '-i' optionStepan Kasal, May 14, 2014
  2. Junio C HamanoMay 14, 2014
  3. Matthieu MoyMay 14, 2014
  4. Jonathan NiederMay 14, 2014
  5. Junio C HamanoMay 14, 2014
  6. Johannes SchindelinMay 15, 2014
  7. Jonathan NiederMay 15, 2014
  8. Johannes SchindelinMay 15, 2014
  9. Junio C HamanoMay 15, 2014
  10. Stepan KasalMay 14, 2014
  11. Jeff KingMay 14, 2014
  12. Johannes SchindelinMay 15, 2014
  13. Jonathan NiederMay 15, 2014
  14. Jeff KingMay 15, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.